-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on-prem: cockpit create image wizard (HMS-5301) #2735
Open
kingsleyzissou
wants to merge
14
commits into
osbuild:main
Choose a base branch
from
kingsleyzissou:cockpit_wizard
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schutzbot
changed the title
on-prem: cockpit create image wizard
on-prem: cockpit create image wizard (HMS-5301)
Jan 10, 2025
kingsleyzissou
force-pushed
the
cockpit_wizard
branch
from
January 10, 2025 13:21
d2a1b9f
to
aea2b03
Compare
This depends on #2704 |
kingsleyzissou
force-pushed
the
cockpit_wizard
branch
2 times, most recently
from
January 13, 2025 09:39
d5adf33
to
1c6e08c
Compare
Marking as draft as this also depends on #2739 |
kingsleyzissou
force-pushed
the
cockpit_wizard
branch
3 times, most recently
from
January 20, 2025 12:13
afa0ced
to
ba3bf8a
Compare
kingsleyzissou
force-pushed
the
cockpit_wizard
branch
from
January 21, 2025 10:55
ba3bf8a
to
a516068
Compare
The browser router doesn't seem to work inside cockpit, switching to the hashrouter resolves this.
Switch the useFlag usage to the stub function defined in the `useGetEnvironment` utility
We need to check for the on-prem use case
We were making a call to a dead endpoint to get the architectures. Instead, create a custom query function to return the list of architectures and image types.
Create a get blueprint endpoint for the on-prem store.
Create the boilerplate function for getting the Oscap profiles. We will need to make a call to the `oscap` binary to get this information. So we will leave it empty for now.
Create a helper hook for RTK prefetch queries. This wrapper function is needed since the imagebuilderApi and cockpitApi aren't at parity yet.
Currently, the wizard still needs some of the other stores. If we omit them, the wizard fails to launch
Including an image in the on prem version inside cockpit is not trivial. We need a bit of a workaround to get the various target icons showing on the on-prem version in cockpit.
For a start, we will disable custom repositories and the OpenSCAP steps for the on-prem version of the frontend.
Subject says it all
kingsleyzissou
force-pushed
the
cockpit_wizard
branch
from
January 23, 2025 14:18
a516068
to
33c9ef1
Compare
kingsleyzissou
force-pushed
the
cockpit_wizard
branch
2 times, most recently
from
January 23, 2025 15:16
2efa12f
to
cb3d3e8
Compare
kingsleyzissou
force-pushed
the
cockpit_wizard
branch
from
January 23, 2025 15:17
cb3d3e8
to
9b58183
Compare
Add a stub function for the `os-release` package from cockpit.
kingsleyzissou
force-pushed
the
cockpit_wizard
branch
from
January 23, 2025 15:56
9b58183
to
76a353c
Compare
Screen.Recording.2025-01-23.at.16.08.09.movThis doesn't include:
|
Add a hook that gets the host distro for the on-prem frontend. If there is an issue we will fallback to the default. For the service we also just use the default distro.
kingsleyzissou
force-pushed
the
cockpit_wizard
branch
from
January 23, 2025 16:11
76a353c
to
bc016ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some changes for us to open the create image wizard for on-prem:
/jira-epic COMPOSER-2411
JIRA: HMS-5301